-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permalink Control #589
Comments
ol.RendererHints.createFromQueryData, which we currently have, is relevant to the discussion. It's also not clear whether the permalink feature will be implemented as a control. Currently ol3 controls have HTTP markup. |
I think that we all agree that this should be the responsibility of the application. Please re-open if you disagree. |
I don't think that this should just be part of the application itself. The OL framework should provide best practises for GIS related standards, which IMHO also includes permalink url shortcuts. V 2.x had also this feature, is there a good reason to keep it seperated and to force devs to code their own implementation? |
I think there is a good reason: there are many ways to implement permalinks. For example, the map state may be encoded in the query part of the URL, or in the hash part of the URL (after the See http://openlayers.org/en/master/examples/permalink.html for an example. |
It's true, as you write there are a lot of ways to accomblish this features. So customization is a must. BUT I see also good reasons to include a ready-to-use feature for permalinks:
|
I agree with @elemoine. The OL2 permalink dates from the early days of web mapping, when maps were much simpler than they are now. OSM still has a simple model, with just a couple of tile layers, no vectors, and not much 'map state' to store. It now uses Leaflet, though this doesn't provide a permalink either; its link share is site-specific. You're assuming that all maps have such a simple structure, but an OL3 map can have layers with different opacity/visibility/brightness/etc; it can have numerous vector layers, which may be clustered, have different styling, and/or be labelled; the vector data may be volatile, in which case you probably want some kind of caching or storage rather than a link. How much of all this you want to reproduce when sharing maps is going to be application-specific, and probably impossible to define in a simple link anyway. Personally I use a JSON object to store map definitions. |
No description provided.
The text was updated successfully, but these errors were encountered: