Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation broken on Image layers with extent #9585

Closed
ahocevar opened this issue May 21, 2019 · 2 comments · Fixed by #9930
Closed

Rotation broken on Image layers with extent #9585

ahocevar opened this issue May 21, 2019 · 2 comments · Fixed by #9930
Labels
regression
Milestone
v6.0.0

Comments

@ahocevar
Copy link
Member

Describe the bug
Image layers with an extent set disappear (at least partially) on rotated views

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://openlayers.org/en/master/examples/wms-image.html
  2. Rotate the map (e.g. with alt-shift-drag)
  3. See the wms overlay disappear

Expected behavior
The wms overlay should be properly displayed when rotated.
@ahocevar ahocevar added this to the v6.0.0 milestone May 21, 2019
@mike-000 mike-000 mentioned this issue Jun 28, 2019
Closed
@mike-000
Copy link
Contributor

In the case of the WMS example this.clip in ol/renderer/canvas/ImageLayer.renderFrame should be this.clipUnrotated https://codesandbox.io/s/wms-image-1ymck (but I've not checked for unwanted side effects when using image sources other than WMS).

@ahocevar
Copy link
Member Author

That sounds right @mike-000. Would you be able to create a pull request? Thanks!

mike-000 added a commit to mike-000/openlayers that referenced this issue Sep 13, 2019
@mike-000
Correct clipping error seen in openlayers#9585
50be36f 
Clipping does not need to consider view rotation
@mike-000 mike-000 mentioned this issue Sep 13, 2019
Merged
mike-000 added a commit to mike-000/openlayers that referenced this issue Sep 20, 2019
@mike-000
New test for Image layer with extent and rotation
e782f90 
Follow up for openlayers#9585/openlayers#9930
mike-000 added a commit to mike-000/openlayers that referenced this issue Sep 20, 2019
@mike-000
New test for Image layer with extent and rotation
52125e7 
Follow up for openlayers#9585/openlayers#9930
@mike-000 mike-000 mentioned this issue Sep 20, 2019
Merged
@mike-000 mike-000 mentioned this issue Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

Correct extent clipping in ImageLayer mike-000/openlayers
2 participants
@ahocevar @mike-000