Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getResolutionforzoom #1

Closed
wants to merge 1 commit into from
Closed

getResolutionforzoom #1

wants to merge 1 commit into from

Conversation

patzi
Copy link

@patzi patzi commented Jun 21, 2012

HI,
shouldn't it also be checked if there is a resolutions entry for the requested zoom?
or should it throw an error if resolutions are defined but not for the requested zoom?

greetings patzi

@elemoine
Copy link
Member

getResolutionForZoom is not part of the API, and it may be that getResolutionForZoom assumes that it gets passed valid zoom values. In that case we should add an assertion (goog.asserts.assert) to verify that zoom is "in range" in the case where the map has resolutions.

@patzi
Copy link
Author

patzi commented Jun 26, 2012

OK, now I see the library gets separated and only the stuff in the api sub folder should be considered to be executed by a user, shouldn't it? stuff in the ol sub folder are then "private" or internal methods

@patzi patzi closed this Jun 26, 2012
@elemoine
Copy link
Member

That's correct.

fredj pushed a commit that referenced this pull request Sep 9, 2013
Rename externs/html5.js to externs/closure-compiler.js
fredj referenced this pull request in fredj/openlayers Mar 10, 2014
Miscellaneous pointer events updates
ahocevar pushed a commit that referenced this pull request Oct 8, 2015
Test Merge openlayers master
elemoine pushed a commit that referenced this pull request Oct 9, 2015
marcjansen pushed a commit that referenced this pull request Jan 20, 2016
Type fixes and simplifications
ahocevar pushed a commit that referenced this pull request Jan 9, 2020
Fixing issue #10497 on behalf of LarryHuang
ahocevar pushed a commit that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants