Should be able to ovveride defaultvalue of style in selection. #10138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
null or false should be able to prevent overriding the style. As discussed here: #10131
jahow
reviewed
Oct 17, 2019
There was a problem hiding this comment.
This is a nice improvement, thanks. Could you please update the documentation here, and make it clear that providing a falsy value will make it so that the style of the selected feature will not change?
https://github.com/openlayers/openlayers/pull/10138/files#diff-9a7ba5dc076db4048de146ccd3df4127R61-R63
Updated docs for Select style with new option of false.
jahow
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null or false should be able to prevent overriding the style.
As discussed here: #10131