Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow root #10698

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Shadow root #10698

merged 2 commits into from
Feb 19, 2020

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Feb 18, 2020

Fixes #10162.

In addition to making events work when the map's root node is a ShadowRoot, this pull request adds an example that shows how to create a custom element with a map.

@matuisti
Copy link

I tested this and it seems to work right.

Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks

@ahocevar ahocevar merged commit 502bb8a into openlayers:master Feb 19, 2020
@ahocevar ahocevar deleted the shadow-root branch February 19, 2020 12:45
@DeleteElf
Copy link

im use 6.1.1 and update to openlayers-master, singleclick cant work in iphone by this change

@DeleteElf
Copy link

i am use 6.1.1 and update to openlayers-master, singleclick can not work in iphone by this change

@ahocevar
Copy link
Member Author

@DeleteElf Please use npm install ol@dev to get a version that includes this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stopEvent not working in shadow-root
4 participants