Make Select interaction work when there are multiple instances #10699
Conversation
| feature.setStyle(this.featureStyleAssociation_[key]); | ||
| delete this.featureStyleAssociation_[key]; | ||
| const selectInteractions = /** @type {Array<Select>} */ (this.getMap().getInteractions().getArray().filter(function(interaction) { | ||
| return interaction instanceof Select && interaction.getFeatures().getArray().indexOf(feature) !== -1; |
There was a problem hiding this comment.
Thanks @ahocevar for this PR. It seems to me that the filter condition should check if the feature has style.
return interaction instanceof Select && interaction.getStyle() && interaction.getFeatures().getArray().indexOf(feature) !== -1;There was a problem hiding this comment.
@michalzielanski interaction.getStyle() !== false to be precise:
style: Style for the selected features. By default the default edit style is used (see module:ol/style). If set to false the selected feature's style will not change.
Can you create a follow-up pull request?
There was a problem hiding this comment.
In other places there is no strong type checking. There is only if (this.style_), so null instead of false will also work. Using interaction.getStyle() !== false only here will cause a malfunction if someone uses null instead of false.
Creating PR would take me half a day, you will do it quicker :)
There was a problem hiding this comment.
See #10708. Feel free to buy me a beer @michalzielanski ;-)
Fixes #10501