Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle layer clear event in case clear(true) called #10722

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

jellyedwards
Copy link
Contributor

Should fix #10721 - tests pass.

Handle layer clear event in case clear(true) called as individual delete feature events aren't generated and the layer remains the same.

Copy link
Contributor

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This fix looks great, thanks! Could you please rebase the PR on the master branch so as to only keep the first commit?

and individual delete feature events aren't generated
@jellyedwards jellyedwards reopened this Mar 9, 2020
@jellyedwards
Copy link
Contributor Author

@jahow I made an absolute mess of the rebase, I think I've sorted it now, does this look ok to you?

@jellyedwards jellyedwards requested a review from jahow March 9, 2020 18:38
@jahow
Copy link
Contributor

jahow commented Mar 10, 2020

This is looking great, thanks a lot.

@jahow jahow merged commit 7b4e522 into openlayers:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clear(true) doesn't work for WebGLPoints layer
2 participants