Set background fill style for each declutter label #11011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
reviewed
May 5, 2020
src/ol/render/canvas/Executor.js
Outdated
| @@ -280,6 +280,7 @@ class Executor { | |||
| context.lineTo.apply(context, p1); | |||
| if (fillInstruction) { | |||
| this.alignFill_ = /** @type {boolean} */ (fillInstruction[2]); | |||
| context.fillStyle = /** @type {import("../../colorlike.js").ColorLike} */ (fillInstruction[1]); | |||
There was a problem hiding this comment.
Without a context.save/restore, doesn't this affect subsequent polygon fills?
There was a problem hiding this comment.
It would if the the color isn't set each time, but .fill_() seems to rely on that as it is already doing save and restore for rotation https://github.com/openlayers/openlayers/blob/master/src/ol/render/canvas/Executor.js#L1038
There was a problem hiding this comment.
Well, since this seems to be an issue only when decluttering, I guess you are right. But then again, wouldn't it be anough to set the fillStyle here only when we're decluttering?
add check for declutter
mike-000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10949
fillStyle needs to be set for each label to handle declutter groups containing different styles