Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace readURI with readStyleURL for KML StyleURLs #11732

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Replace readURI with readStyleURL for KML StyleURLs #11732

merged 1 commit into from
Nov 10, 2020

Conversation

mike-000
Copy link
Contributor

Fixes incorrect style from pairs in #11714

New function readStyleURL ensures StyleURL begins with # if it does not contain one.

@mike-000 mike-000 marked this pull request as draft November 10, 2020 14:29
@mike-000
Replace readURI with readStyleURL for StyleURLs
5d8212e 
readStyleURL ensures URL begins with # if it does not contain one
Remove old partial fix
Test handling of missing # in StyleURL
@mike-000 mike-000 marked this pull request as ready for review November 10, 2020 14:49
ahocevar
ahocevar approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mike-000!

@ahocevar ahocevar merged commit 05b6386 into openlayers:main Nov 10, 2020
@mike-000 mike-000 mentioned this pull request Nov 10, 2020
Closed
@mike-000 mike-000 deleted the patch-23 branch November 10, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahocevar ahocevar ahocevar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mike-000 @ahocevar