Check for graticule resolution change and fix unrotated size #13415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate unrotated width and height from frame size and resolution Check for changes in resolution as well as extent when rendered extent fits inside frame
|
📦 Preview the examples and docs from this branch here: https://deploy-preview-13415--ol-site.netlify.app/. |
ahocevar
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13400
Fixes #13413
Calculating the "unrotated" width and height from the frame size and resolution is simpler than trigonometry and avoids random values when results used in division are close to zero.
Also check for changes to resolution as well as extent when the rendered extent fits inside the frame to ensure the interval is updated when zooming out.