Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional maxWidth for ScaleLine control #13531

Merged
merged 3 commits into from Apr 1, 2022

Conversation

bartvde
Copy link
Member

@bartvde bartvde commented Apr 1, 2022

Add an optional maxWidth config option for the ScaleLine control, so that applications can limit the size of the ScaleLine

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

📦 Preview the examples and docs from this branch here: https://deploy-preview-13531--ol-site.netlify.app/.

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you're able to, it would be great if you could add a test. And I added a suggestion.

src/ol/control/ScaleLine.js Outdated Show resolved Hide resolved
bartvde and others added 2 commits April 1, 2022 13:48
Co-authored-by: Andreas Hocevar <andreas.hocevar@gmail.com>
@bartvde
Copy link
Member Author

bartvde commented Apr 1, 2022

@ahocevar I just added the tests

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, please merge!

@bartvde bartvde merged commit c062599 into openlayers:main Apr 1, 2022
@bartvde bartvde deleted the scaleline_maxwidth branch April 1, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants