Only set interacting hint when modifying the view #1398
Conversation
Hmmm, on my Nexus 7 with this branch I still have this bug. Not sure why yet. |
Thanks a lot for testing @twpayne. There certainly are other bugs. |
|
Here's one: in ol.MapBrowserEventHandler#handleTouchEnd_ we deregister the handleTouchMove_ and handleTouchEnd_ listeners. This means that in the sequence "touchstart (finger 1), touchstart (finger 2), touchend (finger 1), touchend (finger 2)" we won't see the last touchend event because we deregistered the touchend listener on the first touchend event. Similarly if we pan the pan with one finger, then do touchstart touchend with a second finger, then you can no longer with the first finger - the touchmove listener was deregistered when the second finger caused a touchend. |
|
I added a commit to conditionally register/deregister the touchend listener. |
|
I'm testing |
|
It works if you release the 2 fingers in the same time. If you pinch then release a finger then release the 2nd finger, the rerender of the vector layer is not done then it doesn't work forever :) . Probably the event is deregister after the 1st finger is released. |
|
Thanks for testing @oterral. What browser have you used? |
|
Safari and chrome on iOS 7 |
|
Thanks. I'm trying to reproduce it. |
| @@ -135,6 +139,7 @@ ol.interaction.TouchPan.prototype.handleTouchStart = | |||
| // No kinetic as soon as more than one fingers on the screen is | |||
| // detected. This is to prevent nasty pans after pinch. | |||
| this.noKinetic_ = this.targetTouches.length > 1; | |||
| view.setHint(ol.ViewHint.INTERACTING, 1); | |||
There was a problem hiding this comment.
Possible issue here: ol.ViewHint.INTERACTING is incremented on every new touch:
this.targetTouches.length > 0
but decremented only when the last touch leaves the screen:
this.targetTouches.length === 0
|
Thanks for the comments @fredj. I'm closing this PR in favor of a new one. |
No need to go 10 times around the globe
This PR follows up on #1277 by applying the same changes to the touch interaction.
This should also fix a bug in the vector-api branch where vector layers are not redrawn after pinch-zooming. @oterral, you can use my
vector-api-interaction-hintif you want to test my commit with the vector-api branch.Please test and review.