Avoid append only cache in WebGL tile layers #13997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebGL tile renderer maintains its own cache of tile textures. When a layer is configured with an explicit
cacheSize
, this is passed to the renderer's cache. And the intention is that the source's cache remains near empty. In #12671, the cache size for the data tile source was set to 0.1 to make sure it stays empty. But for all other tile sources, the source's tile cache has a size of 0 or unlimited.The Canvas tile renderer calls
source.updateCacheSize()
to manage the cache on its layers' sources. This change makes the WebGL tile renderer do the same. (Having the renderer reach through the layer and the source to manage the tile cache is further support for moving the cache to the renderer instead of the source.)Fixes #13927.