Make track properties in Link interaction configurable #14126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14126--ol-site.netlify.app/. |
tschaub
reviewed
Sep 16, 2022
src/ol/interaction/Link.js
Outdated
| /** | ||
| * @typedef {Object} Options | ||
| * @property {boolean|import('../View.js').AnimationOptions} [animate=true] Animate view transitions. | ||
| * @property {Array<TrackProperties>} [trackProperties=['x', 'y', 'z', 'r', 'l']] Properties to track. Default is to track |
There was a problem hiding this comment.
Minor nit, when reading this below, I keep thinking of "track" the noun, like a racetrack or a GPS track. Feels like properties or params (maybe overused, but I think people know "query params") would be more natural.
tschaub
approved these changes
Sep 16, 2022
ahocevar
force-pushed
the
link-properties
branch
from
2d92d7e
to
87c8608
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
trackPropertiesoption tool/interaction/Link. With that, users can e.g. opt out of tracking the visible layers.In addition, this pull request fixes an issue with history state when it is not purely managed by the Link interaction. This is done by passing the current
history.stateas first argument tohistory.pushState()orhistory.replaceState()