Correct return type for ol/layer/VectorTile~getFeatures() #14165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14165--ol-site.netlify.app/. |
MoonE
commented
Oct 3, 2022
src/ol/render/canvas/hitdetect.js
Outdated
| @@ -192,5 +193,5 @@ export function hitDetect(pixel, features, imageData) { | |||
| resultFeatures.push(features[i / indexFactor - 1]); | |||
| } | |||
| } | |||
| return resultFeatures; | |||
| return /** @type {Array<F>} */ (resultFeatures); | |||
There was a problem hiding this comment.
Not sure why it doesn't work without this cast. Its simply copying features from the input array to the returned array ....
| return accumulator.concat(sourceTile.getFeatures()); | ||
| }, []); | ||
| let hitDetectionImageData = tile.hitDetectionImageData[layerUid]; | ||
| if (!hitDetectionImageData && !this.animatingOrInteracting_) { |
There was a problem hiding this comment.
this.animatingOrInteracting_ does not exist in ol/renderer/canvas/VectorTileLayer, so I removed it. Should be ok to ignore interactions as the hitdetect image is per tile. Not sure about animations.
tschaub
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ol/layer/VectorTilemay also returnol/render/Feature. Currently the return type is alwaysol/Feature.