Use arrow functions instead of binding anonymous functions #14170
Conversation
| @@ -116,7 +116,7 @@ class ReprojDataTile extends DataTile { | |||
|
|
|||
| /** | |||
| * @private | |||
| * @type {!Array<import("../Tile.js").default>} | |||
| * @type {!Array<DataTile>} | |||
There was a problem hiding this comment.
The reproject_ method below assumes these are data tiles, but TypeScript didn't notice with the previous syntax.
| @@ -103,7 +103,7 @@ class ReprojTile extends Tile { | |||
|
|
|||
| /** | |||
| * @private | |||
| * @type {!Array<import("../Tile.js").default>} | |||
| * @type {!Array<ReprojTile|import("../ImageTile.js").default>} | |||
There was a problem hiding this comment.
Use of tile.getImage() below doesn't work with the base tile class.
There was a problem hiding this comment.
Can source tiles be ReprojTiles?
I believe the return type of getTileInternal should be TileImage only.
openlayers/src/ol/source/TileImage.js
Lines 356 to 365 in 66fb11b
createTile_ always returns TileImage and the cache should also only contains this type.
| @@ -106,6 +106,7 @@ export const AttributeType = { | |||
| * @typedef {Object} UniformInternalDescription | |||
| * @property {string} name Name | |||
| * @property {UniformValue} [value] Value | |||
| * @property {UniformValue} [prevValue] The previous value. | |||
There was a problem hiding this comment.
This property was missing but unnoticed due to the use of bind on an anonymous function.
| @@ -46,7 +46,7 @@ const DEFAULT_FRAGMENT_SHADER = ` | |||
| /** | |||
| * @typedef {Object} UniformInternalDescription | |||
| * @property {import("./Helper").UniformValue} value Value | |||
| * @property {number} location Location | |||
| * @property {WebGLUniformLocation} location Location | |||
There was a problem hiding this comment.
TypeScript recognized that this type was wrong after removing bind on anonymous function below.
|
📦 Preview the website for this branch here: https://deploy-preview-14170--ol-site.netlify.app/. |
This makes use of arrow functions instead of creating an unnecessary anonymous function and calling bind on it. It appears that TypeScript does a better job interpreting these arrow functions, so this change required a few updates to types.