Avoid creating tiles with one row each #14260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14260--ol-site.netlify.app/. |
ahocevar
reviewed
Nov 5, 2022
| @@ -108,6 +108,8 @@ function readRGB(preference, image) { | |||
| const STATISTICS_MAXIMUM = 'STATISTICS_MAXIMUM'; | |||
| const STATISTICS_MINIMUM = 'STATISTICS_MINIMUM'; | |||
|
|
|||
| const defaultTileSize = 256; | |||
There was a problem hiding this comment.
Is 256 an arbitrary value, or did you choose this purposely over e.g. 512?
There was a problem hiding this comment.
We probably need to see how this works out in practice. If we make it too large, and the image is very wide, it could take a long time to load and parse - since the range requests will be for batches of rows that span the whole image width.
ahocevar
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the GeoTIFF source is used with imagery that doesn't have tiled layout, we end up creating one tile (and one HTTP request) per strip. In cases where there is only one row per strip, this is a lot of extra overhead. This change makes it so we try to fetch larger blocks of data, organizing things internally as 256x256 tiles if the image has does not have a tiled layout.
I've included an additional commit in this branch that ensures that the GeoTIFF source
getViewmethod resolves to a view with at least three zoom levels. When using GeoTIFFs that only have a single overview or have no overviews, the map is jumpy and frustrating to interact with. This is mostly due to the constraint added due to theextentin the resolved view. I think it would be a breaking change to remove theextentfrom the resolved view, so in this branch I'm only ensuring that there are at least three zoom levels to make things less frustrating.