Ensure gl context is cleared in ol/source/Raster
#14414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14414--ol-site.netlify.app/. |
mike-000
force-pushed
the
raster-webgl-alpha
branch
from
adb5ad1
to
ef1be32
Compare
mike-000
force-pushed
the
raster-webgl-alpha
branch
from
5cb0c4d
to
5475d3d
Compare
mike-000
changed the title
ol/source/Rasterol/source/Raster
tschaub
approved these changes
Jan 2, 2023
This was referenced Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14408
Fixes #14409
Reset the
frameState.renderTargetswhen setting theframeState.layerIndexbefore getting theimageDatafor each input layer. This ensures the gl context is cleared as it would be when rendered directly from the map.As well as fixing the above issues this also fixes drawing over the same uncleared context when multiple WebGL sources are used in an
ol/source/Raster. A new test returns the alpha of each of three sources as red, green and blue which previously would have returned white due to each being draw over the other sources.