Use .transform() instead of .setTransform() when rendering image or text

[mike-000]

Fixes #14478

Allows rotated images and text, and line placement text to be displayed offset as expected following a context translate() or scale() in a prerender event. No rendering tests broken by this change.

Also fix similar issue in immediate renderer.

[github-actions]

📦 Preview the website for this branch here: https://deploy-preview-14483--ol-site.netlify.app/.

[kevmcgrath]

Hi @mike-000,

We're eager for this fix, which also addresses #14478 and see that it didn't make it into v7.3. Do you know if there are plans to include it in the next release? The issue is unfortunately holding up one of our projects.

Kind Regards,
Kevin

[ahocevar]

@mike-000 Thanks for this fix. I think what changes for users now is that postrender needs to reset any transforms that prerender sets. It would be good to test if this is indeed the case, and if so, add at least a paragraph in the release notes.

[mike-000]

@mike-000 Thanks for this fix. I think what changes for users now is that postrender needs to reset any transforms that prerender sets. It would be good to test if this is indeed the case, and if so, add at least a paragraph in the release notes.

In most cases that would already been required - in drawImageOrLabel() setTransform was called inside a save/restore just as transform is now. Only if the immediate renderer had called context.setTransform(1, 0, 0, 1, 0, 0) to revert a previous setTransform - which only happened if the style had scale or rotation - would it not have been necessary, but in that case the transform set by the application would not have had the expected effect on the rendering. For example set the CircleStyle scale to anything other than 1 in https://codesandbox.io/s/feature-move-animation-forked-6vt3o9 and the translated copy of the feature does not appear.

[kevmcgrath]

May I get an update on this? We're still hoping this fix gets included in a future release.

[ahocevar]

@mike-000 Thanks for this fix. Now that we've some backwards incompatible changes lined up already, could you maybe rebase this pull request and move the upgrade notes into the "backwards incompatible changes" section? Thanks in advance!

[ahocevar]

Thanks, @mike-000

[kevmcgrath]

Thank you, @mike-000 and @ahocevar!

[tschaub]

@kevmcgrath - you may know this already, but we create a dev tagged release after every merge to the default branch. So you can get this fix with npm install ol@dev. As mentioned above, we have rolled in some other backwards incompatible changes, so the next stable release will be 8.0. See the upgrade notes for changes you might need to know about that aren't yet in a stable release.

And the dev releases pass all the same tests that our stable releases do, so you shouldn't really think about it as "unstable." But it does mean that the version number might not reflect the nature of the changes since the previous dev release.