Improve the performance of remove Snap interaction #14516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
requested changes
Feb 18, 2023
src/ol/interaction/Snap.js
Outdated
| @@ -381,7 +381,8 @@ class Snap extends PointerInteraction { | |||
| if (currentMap) { | |||
| keys.forEach(unlistenByKey); | |||
| keys.length = 0; | |||
| features.forEach(this.forEachFeatureRemove_.bind(this)); | |||
| this.rBush_.clear(); | |||
| features.forEach(this.unlistenFeatureChange_.bind(this)); | |||
There was a problem hiding this comment.
You could speed this up even more by getting rid of the new unlistenFeatureChange_ method and this change:
Suggested change
| features.forEach(this.unlistenFeatureChange_.bind(this)); | |
| Object.values(this.featureChangeListenerKeys_).forEach(unlistenByKey); | |
| this.featureChangeListenerKeys_ = {}; |
There was a problem hiding this comment.
Nice! It has been modified in this way
XingGuoZ
force-pushed
the
snap_performance
branch
from
631418c
to
b88a1b9
Compare
Just now, I learned about |
|
📦 Preview the website for this branch here: https://deploy-preview-14516--ol-site.netlify.app/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14515 This commit fixes Issue 14515.
When the Snap Source has 13,000 features，the time of remove Snap Interaction will reduced from 6.5s to 150ms