Make Modify hitdetect mode work with user projection #14638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14638--ol-site.netlify.app/. |
tschaub
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when configuring a Modify interaction with
hitDetect, dragging would not work. This can easily be reproduced by addinguseGeographic(true)to themodify-icon.htmlexample.This pull request adds a missing coordinate transform, and makes sure the modify node
geometryhas the coordinates of, instead of a reference to the modify candidate geometry. This is required to avoid misses due to coordinate transform floating point inaccuracies, which would avoid matching up the node with the r-tree.