Avoid missing tiles for Raster source using Tile layers or sources #14853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14853--ol-site.netlify.app/. |
tschaub
approved these changes
Jun 22, 2023
|
Thanks for digging into this, @ahocevar. I notice that I still see the elevation tiles not render periodically when refreshing https://deploy-preview-14853--ol-site.netlify.app/. I don’t see any partial rendering (only all/nothing), and I think it appears less frequently with this change. So it looks like an improvement. |
|
With your latest commit, I think I'm always seeing the shaded relief render. Looks good! |
|
I think so too. Thanks, @tschaub! |
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the Raster source, which can be seen in the map at the top of https://openlayers.org/: Sometimes not all tiles of the hillshade are displayed. To see this bug, simple reload the website several times - it will reveal itself eventually.
A second chunk of this change removes an unnecessary
layer.changed()call, when we're waiting for an animation of dependent sources to finish.