Add typedef, use underscore for private methods #14925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14925--ol-site.netlify.app/. |
mike-000
force-pushed
the
DblClickDragZoom
branch
from
4a1b174
to
ea4ee47
Compare
Co-authored-by: Andreas Hocevar <andreas.hocevar@gmail.com>
That could also be updated in |
ahocevar
approved these changes
Jul 20, 2023
True, that would be a a nice fix in a separate pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems wrong that a property does not have a typedef and that private methods do not use underscore. I am not familiar with Angular but I suspected the former is causing the issue in https://stackoverflow.com/q/76728961/10118270 As in
ol/interaction/MouseWheelZooma timeout id is declared as{?}.