Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TileJSON source url #14937

Merged
merged 3 commits into from Jul 28, 2023
Merged

Update TileJSON source url #14937

merged 3 commits into from Jul 28, 2023

Conversation

mike-000
Copy link
Contributor

https://a.tiles.mapbox.com/v3/aj.1x1-degrees.json used in several examples is no longer working and the alternative v4 version needs an API key which is inconvenient in CodeSandbox when it is only needed to provide a background context to what the example is demonstrating. An alternative to is directly reference the TileJSON endpoint of an OGC Web Mercator raster source which does not require an API key.

@github-actions
Copy link

📦 Preview the website for this branch here: https://deploy-preview-14937--ol-site.netlify.app/.

@mike-000 mike-000 marked this pull request as ready for review July 22, 2023 18:26
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks weird to enforce the TileJSON format for a data source that supports OGC API Tiles, which we have a dedicated source for. I think it would be nice to use that instead, except for the tilejson example.

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mike-000! It looks like the examples that use elevation tiles from Mapbox's v3 API are also broken. If you have a replacement source at hand, a fix for those would be appreciated too.

@ahocevar ahocevar merged commit 8d3d9c9 into openlayers:main Jul 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants