Remove ol/style/Icon's imgSize property #15059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15059--ol-site.netlify.app/. |
ahocevar
force-pushed
the
image-size
branch
5 times, most recently
from
7585d1c
to
1d68afc
Compare
ahocevar
changed the title
ahocevar
changed the title
mike-000
reviewed
Aug 30, 2023
mike-000
reviewed
Aug 30, 2023
jahow
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
imgSizeproperty and its flat styleicon-img-sizecounterpart, changing the loading sequence so they are no longer needed.The image is now loaded using the simple
ol/Image.load()function instead of the more involvedlistenImage()one, because the waylistenImagedecodes the image was only guaranteed to provide the decoded image for a single render frame, which does not bring a real performance benefit. We could also useol/Image.decode(), but that would make SVG images, which are frequently used as icons, blurry when scaled or on retina displays.