WebGL / Implement tile masking for vector tiles #15127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahow
force-pushed
the
webgl-vector-tiles-no-overlap
branch
from
2775a06
to
8fd38d7
Compare
|
📦 Preview the website for this branch here: https://deploy-preview-15127--ol-site.netlify.app/. |
jahow
force-pushed
the
webgl-vector-tiles-no-overlap
branch
from
8fd38d7
to
e2dd80e
Compare
jahow
force-pushed
the
webgl-vector-tiles-no-overlap
branch
9 times, most recently
from
f251e47
to
9ce6106
Compare
The eliminates the flickering for vector tiles, which happened because there is a delay between a tile being loaded (i.e. having its data loaded) and its buffers ready for rendering.
It is not possible anymore to provide full explicit shaders to the VectorStyleRenderer class, as this would most likely break very often. Instead, a preconfigured builder should be provided. Note: a literal style can still be provided as well.
This will not be run by default, unless beforeTilesMaskRender returns true
The tile mask is a render target that contains the values of the highest drawn zoom level for each pixel. This can then be used when rendering the actual tiles to mask tiles below the highest ones, thus avoiding overlapping. Also added support for depth in ShaderBuilder.
jahow
force-pushed
the
webgl-vector-tiles-no-overlap
branch
from
9ce6106
to
e691cf3
Compare
tschaub
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the concept of tile masking for the WebGL Vector Tile renderer. This allows a cleaner visible output by making sure that tiles of lower zoom levels will not show through tiles of higher zoom levels.
Also got rid of the flickering effect that used to be very noticeable.
This PR also changes the API of the
VectorStyleRendererclass by not allowing full explicit shaders as string anymore, but instead taking in aShaderBuilderinstance that was preconfigured.See an example of higher tiles masking lower ones:
