More strict type checks #15189
Merged
More strict type checks #15189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15189--ol-site.netlify.app/. |
ahocevar
reviewed
Sep 27, 2023
src/ol/tilegrid/TileGrid.js
Outdated
Comment on lines
268
to
269
| x = Math.floor(/** @type {number} */ (x) / 2); | ||
| y = Math.floor(/** @type {number} */ (y) / 2); |
There was a problem hiding this comment.
I'm wondering if these type casts could be avoided when the wrapping if clause is changed from
if (this.zoomFactor_ === 2) {to
if (x !== undefined && y !== undefined) {
MoonE
force-pushed
the
strict-type-checking
branch
from
3990266
to
1c7e551
Compare
tschaub
approved these changes
Sep 28, 2023
ahocevar
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.