Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow touch-action: pan-x pan-y; on viewport #15208

Merged
merged 1 commit into from Oct 6, 2023

Conversation

mike-000
Copy link
Contributor

@mike-000 mike-000 commented Oct 5, 2023

Possible fix for #9936 (comment)

Explicitly setting touch-action: pan-x pan-y; seems to fix the issue described on Android Chrome, but unlike touch-action: none; it can cause a pull-to-refresh to be triggered, which may be unexpected.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

📦 Preview the website for this branch here: https://deploy-preview-15208--ol-site.netlify.app/.

@ahocevar
Copy link
Member

ahocevar commented Oct 5, 2023

This fixes the problem for me on iOS.

@mike-000 mike-000 marked this pull request as ready for review October 5, 2023 19:53
@mike-000
Copy link
Contributor Author

mike-000 commented Oct 5, 2023

Since v7.0.0 all versions of the examples have been using ol.css from the website theme folder, which is a copy of the latest version css. It could become incompatible with those versions and makes it difficult to identity when problems were introduced.

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mike-000

@ahocevar ahocevar merged commit 1f9250c into openlayers:main Oct 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants