Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShaderBuilder for with symbolRotateWithView #15229

Merged
merged 2 commits into from Oct 24, 2023

Conversation

kikuchan
Copy link
Contributor

@kikuchan kikuchan commented Oct 9, 2023

Try to close #15228

@kikuchan
Copy link
Contributor Author

kikuchan commented Oct 9, 2023

Actually, this solve the issue, but I'm not sure the correctness because I have no idea why the pxToScreen had an unnecessary code for scaling and rotation here.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

📦 Preview the website for this branch here: https://deploy-preview-15229--ol-site.netlify.app/.

Copy link
Contributor

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix @kikuchan, it actually makes complete sense. The computation logic was simply wrong. Kudos for managing to figure that out!

@jahow jahow merged commit a6de455 into openlayers:main Oct 24, 2023
8 checks passed
@kikuchan kikuchan deleted the fix-shader-builder branch October 24, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon distortion on WebGLPoints layer
2 participants