fix(Map): use same size calculation in updateSize and updateViewportSize_
#15269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15269--ol-site.netlify.app/. |
simonseyock
force-pushed
the
fix-update-viewport-size
branch
2 times, most recently
from
240973c
to
20121de
Compare
simonseyock
force-pushed
the
fix-update-viewport-size
branch
from
20121de
to
024d165
Compare
ahocevar
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Good simplification. Thanks, @simonseyock. I have added a suggestion for simpler wording that you may want to consider. Looks good otherwise.
|
Just to clarify: This not only simplifies it, but also fixes a bug that was occurring in the removed code part. |
|
Also I updated the docs for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15268