WebGL / Improve line antialiasing #15554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15554--ol-site.netlify.app/. |
jahow
force-pushed
the
webgl-fix-line-antialiasing
branch
2 times, most recently
from
a820f78
to
a1c8452
Compare
ahocevar
approved these changes
Feb 14, 2024
Comment on lines
107
to
110
| requestAnimationFrame(() => { | ||
| map.renderSync(); | ||
| render({ | ||
| message: 'renders four polygons with various pattern fills', | ||
| }); |
There was a problem hiding this comment.
I'm wondering if it wouldn't be better to do something like this instead:
map.once('rendercomplete', () => {
render({
message: 'renders four polygons with various pattern fills',
});
});There was a problem hiding this comment.
Amended the first commit with this change
jahow
force-pushed
the
webgl-fix-line-antialiasing
branch
from
a1c8452
to
f30e34f
Compare
This makes sure that icons are loaded before rendering
Antialiasing is now done on the +0.5 -0.5 range; previously it was done on the +0 -1 range, which meant line width was always 1px less that expected
jahow
force-pushed
the
webgl-fix-line-antialiasing
branch
from
47b8e14
to
ae4b923
Compare
|
thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antialiasing is now done on the
+0.5 -0.5range; previously it was done on the+0 -1range, which meant line width was always 1px less that expected.Before (line of 1px width):
After:
This PR also contains a workaround for the webgl fill and line patterns that sometimes fail because the images might not be ready for rendering.