Fix decluttering opacity, zIndex and circles #15614
Merged
+167
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15614--ol-site.netlify.app/. |
ahocevar
force-pushed
the
declutter-opacity-circle-zindex
branch
from
67cff23
to
4ca4308
Compare
ahocevar
commented
Mar 5, 2024
Comment on lines
429
to
431
| for (const key in deferredZIndexContexts) { | ||
| deferredZIndexContexts[key].forEach((zIndexContext) => { | ||
| const zs = Object.keys(deferredZIndexContexts).sort(ascending); | ||
| for (let i = 0, ii = zs.length; i < ii; ++i) { | ||
| deferredZIndexContexts[zs[i]].forEach((zIndexContext) => { |
There was a problem hiding this comment.
Sorting makes sure that styles with negative zIndex will be rendered before styles with positive zIndex.
There was a problem hiding this comment.
Do we care that a z-index of -1 will be sorted before -10 (and 10 before 2)?
There was a problem hiding this comment.
Oh, thanks for spotting this. I just committed a fix. Postitive numbers were already sorted properly though, because the ascending() sort function takes care of that.
ahocevar
force-pushed
the
declutter-opacity-circle-zindex
branch
from
4ca4308
to
821001b
Compare
ahocevar
commented
Mar 5, 2024
ahocevar
commented
Mar 14, 2024
tschaub
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on a fix for #15611 (point symbols disappearing on vector layers with opacity != 1) I created a new rendering test, which revealed two more issues:
Circlegeometries are not rendered when declutteringzIndexare rendered after styles with positivezIndex.All these are fixed now.
Fixes #15611.