Clear RenderBox on DragBox Deactivation #15671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15671--ol-site.netlify.app/. |
Co-authored-by: Andreas Hocevar <andreas.hocevar@gmail.com>
M393
reviewed
Mar 26, 2024
Co-authored-by: M393 <56256405+M393@users.noreply.github.com>
ahocevar
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the DragBox interaction is deactivated by calling
setActive(false), the RenderBox (which visually represents the dragged area) remains on the map. This Pull Request should resolve #15571 by clearing the RenderBox when the DragBox is deactivated.Changes
In the
setActivemethod of theDragBoxclass, a new line has been added to call thedisposeInternalmethod of thebox_(RenderBox) instance when active is set tofalse. This will ensure that the RenderBox is properly disposed and removed from the map.