Tile render order #15685
Merged
Tile render order #15685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15685--ol-site.netlify.app/. |
ahocevar
force-pushed
the
tile-render-order
branch
7 times, most recently
from
088c7b7
to
3c9da36
Compare
ahocevar
force-pushed
the
tile-render-order
branch
from
3c9da36
to
da3ef00
Compare
|
This is now ready for review. |
tschaub
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the vector tile render order from per-tile to per-viewport for
declutter: false, and from per-zIndex to per-zIndex-and-builderType. Fordeclutter: true, the general order has already been per-viewport. This makes sure that within the same z-index, the render order of the builder types is maintained across tiles.Now the viewport is rendered as a whole, instead of tile-by-tile. This is done by changing the ZIndexContext's index from just
render zIndextorender zIndex * maximum number of builder types. When not decluttering, we now also use the deferred rendering code path, which was originally created for decluttering - to collect all executors of all tiles in the viewport and then render them together, zIndex by zIndex, and builderType by builderType. Previously, tiles were rendered one after another.Fixes #15681.