Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terrain-rgb URL Fixes #15686 #15687

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

bolollo
Copy link
Contributor

@bolollo bolollo commented Mar 29, 2024

Fixes #15686

Chage the URL to use the current tileset https://api.maptiler.com/tiles/terrain-rgb-v2/{z}/{x}/{y}.webp

@mike-000
Copy link
Contributor

This was also noted #15403 (comment) The url should be updated, but for the example to demonstrate the undesired effect of interpolation when overzooming the maxZoom should not be increased.

@bolollo bolollo changed the title Update terrain-rgb URL and change maxZoom to 14 Fixes #15686 Update terrain-rgb URL Fixes #15686 Mar 29, 2024
@bolollo
Copy link
Contributor Author

bolollo commented Mar 29, 2024

This was also noted #15403 (comment) The url should be updated, but for the example to demonstrate the undesired effect of interpolation when overzooming the maxZoom should not be increased.

Ok, I have updated the PR. Now, I only updated the URL. Thanks

Copy link

📦 Preview the website for this branch here: https://deploy-preview-15687--ol-site.netlify.app/.

@ahocevar
Copy link
Member

Thanks @bolollo , can you please run npm run lint -- --fix to fix the linter errors? Thanks!

@bolollo
Copy link
Contributor Author

bolollo commented Apr 2, 2024

Thanks @bolollo , can you please run npm run lint -- --fix to fix the linter errors? Thanks!

You're welcome @ahocevar. I have already corrected the linter errors. I thought I had configured my VS code with the "editor.codeActionsOnSave" that would fix the errors. Now, I have configured it correctly.

I'm reviewing the examples that use MapTiler maps, and I will update some to use the latest versions since some are deprecated. For this, is it better to create a ticket for each type of map to be modified, or is it okay to create a ticket to modify all of them?

I have seen that some PRs have already been updated. Thank you.

@ahocevar
Copy link
Member

ahocevar commented Apr 2, 2024

@bolollo You can do that all in a single pull request, but I think #15669 might cover most already.

@ahocevar ahocevar merged commit 0c55996 into openlayers:main Apr 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update terrain-rbg in interpolation examples
3 participants