Fix handling of the color cache #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice catch ! |
elemoine
pushed a commit
that referenced
this pull request
Feb 20, 2014
Fix handling of the color cache
This was referenced Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the size of the color cache exceeds the limit we're supposed to delete 25% of the entries. Currently this does not work – the cache keeps growing.
This is because
(i++ & 3 === 0)always evaluates to 0 (which is a falsy value). This expression always evaluates to 0 because the===operator has precedence over the&operator.This PR fixes the bug by using brackets around the
i++ & 3expression.