-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example labels #1785
Example labels #1785
Conversation
Please can you rebase on the latest master to remove the merge commits. Thanks! |
Sure. |
Very nice example by the way! |
Thank you. Would you please give me a pointer: how do I remove the merge commits ? |
should do it - git is normally clever enough to strip out merge commits. |
Sorry it's taking long, I think I messed up something. My git-fu sucks :) |
It looks like you've added another merge commit. Run
and delete every line that is a merge commit. |
Add forms to let the user change the labels as they want. Text 'Wrap' doesn't work properly. '\n' are supposed to allow line to break.
Add note about the 'Text/Wrap' option currently not working.
What do I need to do now ? Thank you very much for your help. |
|
Thank you. |
Oh, I forgot to mention: the 'Text/Wrap' option in the example didn't work as I expected. If you compare with the OL2 example, you'll see what I mean. In the ol3 example, the '\n' do not break the labels into multiple lines, it looks interpreted as a space character. |
Typo fixes, add 1 more font
+1 from me for merging this. Good work. |
This is because ol3 uses Canvas's |
Thanks @adube! |
Add a new example demonstrating what's possible to do with labels in OL3. It includes 3 geojson dataset samples of points, lines and polygons. In addition, 3 forms allow the user to change text label styling on the-fly and see the result.
See the demo in action . See also an OpenLayers 2.12 equivalent demo.
Comments would be quite welcome.