DOM renderer changes #18

Merged
merged 6 commits into from Aug 22, 2012

Conversation

Projects
None yet
2 participants
@elemoine
Owner

elemoine commented Aug 21, 2012

This pull request makes a few changes to the DOM renderers:

  • handleCenterChanged and handleResolutionChanged now return right away if map is not defined yet.
  • ol.dom.LayerRenderer now defines handleLayerLoad, this is to deal with async tile layers like TileJSON.

The dom map in the two-layers example now (somewhat) works. We see broken tiles in the DOM map, due to the tile store's extent not being taken into account. To be fixed separately.

@twpayne

This comment has been minimized.

Show comment Hide comment
@twpayne

twpayne Aug 21, 2012

Contributor

Looks good. You can also remove a couple of FIXMEs at the top of src/ol/dom/tilelayerrenderer.js:

https://github.com/elemoine/ol3/blob/domrenderer/src/ol/dom/tilelayerrenderer.js#L1

Contributor

twpayne commented Aug 21, 2012

Looks good. You can also remove a couple of FIXMEs at the top of src/ol/dom/tilelayerrenderer.js:

https://github.com/elemoine/ol3/blob/domrenderer/src/ol/dom/tilelayerrenderer.js#L1

@twpayne

This comment has been minimized.

Show comment Hide comment
@twpayne

twpayne Aug 22, 2012

Contributor

The dom map in the two-layers example now (somewhat) works. We see broken tiles in the DOM map, due to the tile store's extent not being taken into account. To be fixed separately.

This is fixed in 7c77b6a.

Contributor

twpayne commented Aug 22, 2012

The dom map in the two-layers example now (somewhat) works. We see broken tiles in the DOM map, due to the tile store's extent not being taken into account. To be fixed separately.

This is fixed in 7c77b6a.

elemoine pushed a commit that referenced this pull request Aug 22, 2012

@elemoine elemoine merged commit 5998c0a into openlayers:exp Aug 22, 2012

@elemoine

This comment has been minimized.

Show comment Hide comment
@elemoine

elemoine Aug 22, 2012

Owner

@twpayne thanks for 7c77b6a!

Owner

elemoine commented Aug 22, 2012

@twpayne thanks for 7c77b6a!

gberaudo pushed a commit to gberaudo/ol3 that referenced this pull request Nov 7, 2014

@elemoine elemoine deleted the elemoine:domrenderer branch Apr 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment