Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM renderer changes #18

Merged
merged 6 commits into from Aug 22, 2012
Merged

DOM renderer changes #18

merged 6 commits into from Aug 22, 2012

Conversation

elemoine
Copy link
Member

This pull request makes a few changes to the DOM renderers:

  • handleCenterChanged and handleResolutionChanged now return right away if map is not defined yet.
  • ol.dom.LayerRenderer now defines handleLayerLoad, this is to deal with async tile layers like TileJSON.

The dom map in the two-layers example now (somewhat) works. We see broken tiles in the DOM map, due to the tile store's extent not being taken into account. To be fixed separately.

@twpayne
Copy link
Contributor

twpayne commented Aug 21, 2012

Looks good. You can also remove a couple of FIXMEs at the top of src/ol/dom/tilelayerrenderer.js:

https://github.com/elemoine/ol3/blob/domrenderer/src/ol/dom/tilelayerrenderer.js#L1

@twpayne
Copy link
Contributor

twpayne commented Aug 22, 2012

The dom map in the two-layers example now (somewhat) works. We see broken tiles in the DOM map, due to the tile store's extent not being taken into account. To be fixed separately.

This is fixed in 7c77b6a.

elemoine pushed a commit that referenced this pull request Aug 22, 2012
@elemoine elemoine merged commit 5998c0a into openlayers:exp Aug 22, 2012
@elemoine
Copy link
Member Author

@twpayne thanks for 7c77b6a!

gberaudo pushed a commit to gberaudo/openlayers that referenced this pull request Nov 7, 2014
@elemoine elemoine deleted the domrenderer branch April 27, 2015 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants