Fix calculation of ends in ol.geom.MultiPolygon#getPolygons #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (i = 0, ii = endss.length; i < ii; ++i) { | ||
| var ends = endss[i]; | ||
| var end = ends[ends.length - 1]; | ||
| var polygon = new ol.geom.Polygon(null); | ||
| var polygonEnds = ends.slice(); | ||
| for (j = 0, jj = polygonEnds.length; j < jj; ++j) { |
There was a problem hiding this comment.
Do you think it is worth avoiding this for the first polygon (offset === 0)?
There was a problem hiding this comment.
Good spot. Will change.
|
Minor optimization comment. Either way, please merge. |
twpayne
added a commit
that referenced
this pull request
Mar 7, 2014
Fix calculation of ends in ol.geom.MultiPolygon#getPolygons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug reported by @pagameba on the mailing list. The polygons returned by
ol.geom.MultiPolygon#getPolygonswere invalid.@ahocevar I suspect that this same bug is present in other
ol.geomclasses, which in turn might be causing #1808. Will investigate.