Geolocation tracking with orientation example #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review. |
| // only keep the 20 last coordinates | ||
| positions.setCoordinates(positions.getCoordinates().slice(-20)); | ||
| // Because we modified flatCoordinates directly | ||
| positions.dispatchChangeEvent(); |
There was a problem hiding this comment.
These two lines are not needed (the flat coordinates are no longer modified directly).
|
Commit fixed up with your comments. |
|
Many thanks! |
twpayne
added a commit
that referenced
this pull request
Mar 24, 2014
Geolocation tracking with orientation example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.