Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delete event and fires doclets #1906

Merged
merged 4 commits into from Mar 27, 2014
Merged

Do not delete event and fires doclets #1906

merged 4 commits into from Mar 27, 2014

Conversation

ahocevar
Copy link
Member

cc @pagameba - this fixes the regression introduced with #1904

@ahocevar
Copy link
Member Author

This needs a bit more work. I'll drop a note when done.

@ahocevar
Copy link
Member Author

This is now ready for review. @pagameba, would be great if you could have a look.

@ahocevar
Do not loop through parents
15b0bc7 
Now that we use the parseComplete event, we walk through all
doclets in the loop anyway.
@pagameba
Copy link
Member

Now it seems that ol.MapEvent is missing entirely from the index and the page isn't generated.

@pagameba
Copy link
Member

But some of the other event types are there, for instance ol.CollectionEvent and ol.DrawEvent

@pagameba
Copy link
Member

Also, not sure if this is intended or not ... events are documented differently with this vs master.

fix-event-docs:
image

image

@ahocevar
Copy link
Member Author

I just noticed this myself. The constructor should not show up in the docs. I'm working on this right now.

@ahocevar
Clean up
a5d8f46 
Only mark symbol as unexported when it is not in the API, and
no longer extract links from fires annotations because all links
are handled now.
@ahocevar
Copy link
Member Author

@pagameba I got it now - I just force pushed a new version of the last commit. To me the exports.js code really looks clean and consistent now, with a distinction between api and unexported.

@pagameba
Copy link
Member

Looks great now.

One very minor comment, div.description has this style: margin-left: -16px coming from jsdoc-default.css:212, visually not that appealing. Not sure if you want to fix this or not, or if its appropriate to fix it in this PR?

image

@pagameba
Copy link
Member

In either case, please merge.

ahocevar added a commit that referenced this pull request Mar 27, 2014
@ahocevar
Merge pull request #1906 from ahocevar/fix-event-docs
47b82f0 
Do not delete event and fires doclets
@ahocevar ahocevar merged commit 47b82f0 into openlayers:master Mar 27, 2014
@ahocevar ahocevar deleted the fix-event-docs branch March 27, 2014 12:00
@pagameba pagameba mentioned this pull request Mar 27, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahocevar @pagameba