Add style and condition for multiple selection to modify example #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed on the hangout - feel free to merge when you're happy with the conditions. |
|
+1 |
tschaub
added a commit
that referenced
this pull request
Mar 27, 2014
Add style and condition for multiple selection to modify example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #1877, it looked like selected features had a distinct style because they were being rendered on top of their unselected counterparts. The change in 1e0d2af gives the select interaction a distinct style to achieve the same.
The changes in #1877 also made it so the shift modifier didn't add to a selection by default. The remaining changes here allow addition to and removal from the selection (with shift-click and any click respectively).