Implement shouldStopEvent in DragBox interaction #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the map is panned when boxes are drawn.
|
LGTM |
|
Thanks @tsauerwein. |
|
Looks good to me as well. |
elemoine
pushed a commit
that referenced
this pull request
Apr 7, 2014
Implement shouldStopEvent in DragBox interaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug reported on the mailing list where the map is panned while boxes are drawn.
Please review.
Note: the shouldStopEvent function was introduced because of the PinchZoom and PinchRotate interactions that need to work together, that is the PinchZoom interaction should not stop event and prevent the PinchRotate interaction to trigger (and vice-versa). We could probably remove the shouldStopEvent hack by combining these two interactions into one.