-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous ol.FeatureOverlay cleanup #2018
Conversation
this.featureChangeListenerKeys_[goog.getUid(feature).toString()] = | ||
goog.events.listen(feature, goog.events.EventType.CHANGE, | ||
this.handleFeatureChange_, false, this); | ||
} | ||
}, this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a real bug right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bug because this
was not unsed inside the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, bad answer.
No, it was not a bug but forEach
is (IMHO) much more simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok got it.
LGTM. |
Thanks for the review |
Miscellaneous ol.FeatureOverlay cleanup
No description provided.