Hit detection respects min and maxResolution #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {ol.layer.LayerState} layerState Layer state. | ||
| * @param {number} resolution Resolution. | ||
| * @return {boolean} Visible at resolution? | ||
| * @public |
There was a problem hiding this comment.
This would be the first @public annotation in the library. Any reason for it?
|
A couple of doc comments, but otherwise this looks good to me. |
|
Thanks for the review. I'll make changes and merge. |
| * the layer's minResolution and maxResolution. | ||
| * @param {ol.layer.LayerState} layerState Layer state. | ||
| * @param {number} resolution Resolution. | ||
| * @return {boolean} Visible at resolution? |
There was a problem hiding this comment.
Also minor, but if you're making doc changes, I'd like to see us start getting consistent about documenting boolean returns. I think they should all be documented as positive assertions. E.g. "The layer is visible at the given resolution." If true, the assertion holds. If false, it doesn't.
elemoine
pushed a commit
that referenced
this pull request
May 25, 2014
Hit detection respects min and maxResolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug reported in #2106, where the hit detection code detects features that are not actually rendered because the current resolution is outside the resolution range defined on the vector layer.
Please review.
closes #2106.