Builds should include license

[bartvde]

shouldn't they? I did ask on the list, but looks like I never got a reply https://groups.google.com/forum/#!searchin/ol3-dev/license/ol3-dev/-R1OwQcKGoQ/ynEuMYFas1AJ

[elemoine]

Yes. The compiler supports @preserve and @license annotations that we could use for that. See https://developers.google.com/closure/compiler/docs/js-for-compiler. Another option is to use the output-wrapper compilation option.

[bartvde]

I recall previous discussion about this (I remember asking about it as well), but I can't find it.

IIRC @twpayne told me it was decided at the Chambery sprint back then that this is not necessary.

[elemoine]

Really? I'd like to hear the reasons.

[bartvde]

maybe I'm mixing up discussions let me look for it again ;-)

[bartvde]

hmm I really can't find it but I do recall this outcome, maybe the discussion was in a hangout or something similar

[tschaub]

Let's follow others and not include the full license text (even though React does). A link to the license should suffice. And including a license name is nice.

[probins]

there's also the question of the licences for software used by the lib. At the moment, builds include credits for spherical geodesy formulae (CC licence) and mochikit (MIT), which is included in Closure, but no mention of Closure itself (Apache 2). This seems illogical to me.

In #1192 I suggest putting the version no in a comment at the front of the file, so how about having a comment along the lines of:

Openlayers 3 [git describe version] license ...
Uses Closure library, version ... license ...
Compiled by Closure compiler version ...
plus any other license links

[twpayne]

From memory, the decision taken in Chambéry was to not include the licence in each source file. I don't remember discussing whether or not to include the licence in the build output.

[bartvde]

thanks for clarifying @twpayne that sounds familiar again ;-)

Sent from my iPhone

On 3 jun. 2014, at 21:33, Tom Payne notifications@github.com wrote:

From memory, the decision taken in Chambéry was to not include the licence in each source file. I don't remember discussing whether or not to include the licence in the build output.

—
Reply to this email directly or view it on GitHub.

[probins]

shouldn't this be in the 3.0.0 milestone?

[bartvde]

Provide url to: https://github.com/openlayers/ol3/blob/master/LICENSE.md

[bartvde]

okay it seems this needs to be done in build.js (addHeader)

[elemoine]

Yes, indeed.

[bartvde]

hey @elemoine what is the purpose of this directory btw: https://github.com/openlayers/ol3/tree/master/licenses ?

[bartvde]

PR attached

[elemoine]

hey @elemoine what is the purpose of this directory btw: https://github.com/openlayers/ol3/tree/master/licenses ?

I guess listing our deps' licenses.

[elemoine]

That looks good to me. Let's wait a bit before merging to see if that makes sense to others.

[pagameba]

Looks good to me based on our discussion.

[elemoine]

I think this is good to merge.