Add tilePixelRatio option to ol.source.WMTS #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Thanks! |
| @@ -2823,6 +2824,16 @@ olx.source.TileImageOptions.prototype.tileLoadFunction; | |||
|
|
|||
|
|
|||
| /** | |||
| * The pixel ratio used by the tile service. For example, if the tile | |||
| * service advertizes 256px by 256px tiles but actually sends 512 px | |||
| * by 512 px images (for retina/hidpi devices) then `tilePixelRatio` | |||
There was a problem hiding this comment.
Minor, but you use 256px (no space) and 512 px (space). Could be made consistent.
|
Two minor doc comments. In my opinion this is good to merge. |
elemoine
pushed a commit
that referenced
this pull request
Jun 19, 2014
Add tilePixelRatio option to ol.source.WMTS
|
Thanks Andreas for the collaboration on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tilePixelRatio option to ol.source.WMTS. This option can be used with WMTS services that send larger tiles (512x512) than advertized (256x256), for high quality rendering on hidpi/retina screens. The PR includes an example (from @ahocevar) demonstrating the use of that option.
Meant to replace #2194.