Fix toggle behaviour of the Select interaction #2243
Conversation
By not taking the skipped features from the frameState, we achieve the flexibility of doing forEachFeatureAtPixel at the map renderer level with a custom set of skipped features.
|
The problem with this approach is that the features will be rendered in the hit detection canvas using the layer's styles. Think about a icon whose size doubles when the feature is selected. Is waiting for #1591 a problem for you? I can put together a PR tomorrow. |
|
Good point. This is an urgent issue for a client of ours. With #1591, how will you trigger hit detection for features on overlays? By implementing a forEachFeatureAtPixel method on ol.FeatureOverlay? I don't think that including them in map.forEachFeatureAtPixel will be a good idea, because then the purpose of layerFilter gets confusing. |
|
Not by implementing forEachFeatureAtPixel in ol.FeatureOverlay, but, yes, reusing the map.forEachFeatureAtPixel API. For features drawn by feature overlays the callback will be passed a |
|
Not sure. At least it will be confusing and needs to be well documented. |
|
@ahocevar this is my branch: https://github.com/elemoine/ol3/compare/replaygroup. It is not complete but it should show you how it is implemented. |
|
#2254 fixes this, so closing. |
Because features on overlays are skipped and therefore not seen by forEachFeatureAtPixel, it is not possible to toggle the selection of a skipped feature. By making the skipped features for forEachFeatureAtPixel configurable at the map renderer level, the Select interaction can do its hit detection without excluding the skipped features of its selection overlay.
The issue was reported on the mailing list, and this is a solution that works independently of #1591.