Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra goog.require calls #2266

Merged
merged 2 commits into from Jun 28, 2014
Merged

Extra goog.require calls #2266

merged 2 commits into from Jun 28, 2014

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Jun 27, 2014

Resisting the urge to write a check-deps.js task ...

@tschaub tschaub changed the title Unnecessary ol.Image require Extra goog.require calls Jun 27, 2014
@tschaub
Copy link
Member Author

tschaub commented Jun 28, 2014

Ok, now I've decided that it is not worth writing a strict check-deps.js task. We only need goog.require calls where 1) code in one module is used in another and 2) the compiler needs @typedef information to check assignment statements.

The two commits above remove goog.require calls that are not strictly required. In these cases, the ol.Image and ol.Tile functions are not accessed in the goog.requireing modules. So it is safe to remove these calls.

We cannot, however, remove goog.require calls for @typedef only provides like ol.Pixel or ol.Coordinate (unless we want to add type casts where ever we assign these types).

@fredj
Copy link
Member

fredj commented Jun 28, 2014

Please merge

tschaub added a commit that referenced this pull request Jun 28, 2014
@tschaub tschaub merged commit 93ece70 into openlayers:master Jun 28, 2014
@tschaub tschaub deleted the extra-require branch June 28, 2014 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants