Add "action type" select to select-features example

[elemoine]

Making it possible to choose between two select interactions, one that works on singleclick ("click") and another one that works on mousemove ("hover").

See https://groups.google.com/d/msg/ol3-dev/JWpcS_31zeg/UTfypkXqBl0J.

[probins]

worth adding an ol.events.condition.mouseMove? That would make it a bit easier

[elemoine]

Yes, possibly.

Also, by default, the select interaction uses a singleClick condition. This means that there's some delay between the click and the actual feature selection.

We could also add ol.events.condition.click for people who want the feature selection to be more responsive, and don't care if feature selection triggers on double-clicks.

We could even make the interaction use ol.events.condition.click by default. I think I tried that in the past but ran into problems. I can't remember what these problems were. I'll maybe give it another try.

[ahocevar]

See #1946 for an old pull request of mine that adds a click condition. The reason why singleclick is used in the examples is to avoid selection on doubleclick-zoom. Having said that, I never was a fan of this, and this is why I created the above pull request to use click in my own applications, where doubleclick zoom is disabled.

[elemoine]

Thanks @ahocevar. See my new commits.

[probins]

I would add a note to select-features.html explaining the difference between click and single-click. In this example, large parts of the viewport are covered by features; if you just have a few points, the click/dbl-click issue doesn't really arise, as people are unlikely to dbl-click on a point anyway.

[marcjansen]

I think the new conditions miss the @todo api annotation, @elemoine.

I agree with @probins that the types in the examples should have a description.

Btw. when assigning the onchangehandler, do we need the wrapping function? Does reading out the value attribute of the select-element work everywhere, i.e. in every supported browser?

Otherwise this looks great to me.

[probins]

I think the new conditions miss the @todo api annotation

well spotted! how come Travis doesn't consider this an error, if they're not exported?

[marcjansen]

AFAICT, the @todo annotation are relevant only to jsdoc.

[elemoine]

AFAICT, the @todo annotation are relevant only to jsdoc.

No, it also makes the symbol exportable.

[elemoine]

well spotted! how come Travis doesn't consider this an error, if they're not exported?

Because we don't de-reference ol.events.condition.click. I was just passing undefined values to the select interactions.

[elemoine]

Review comments taken into account. Please tell me if my changes do address all of your comments. Thanks.

[probins]

lgtm